Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68436.
The original cmp function in CircleInConvex test is malformed:
The above cmp function results in indeterminate behavior, which is strongly coupled with introsort behavior (code really shouldn't assume Array.Sort having a introsort implementation).
Note that If I switch to sort algorithm other than intersort such as heap sort, insertion sort and etc, or even keep the introsort but sort it twice, the CircleInConvex will also fail without this change.
Also, the original
expRes
was incorrect. The newexpRes
is verified using a convex-hull algorithm locally:Convex-hull points:
Origin: (-146892800, 117045950)
Radius: 1.191233E+09
/cc: @jkotas