[release/6.0] [mono] Preserve FirstChanceExceptionEventArgs ctor #68265
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The runtime is creating the exception so we need to preserve it. See dotnet/android#6626
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
rbhanda
added
Servicing-approved
|
@marek-safar @lambdageek can I get your sign-off on this PR so we can get it merged? |
akoeplinger
approved these changes
May 5, 2022
steveisok
approved these changes
May 5, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #68235 to release/6.0
/cc @akoeplinger
Customer Impact
A customer reported in dotnet/android#6626 that a Xamarin Android app crashed when subscribing to the
AppDomain.CurrentDomain.FirstChanceExceptionevent when IL trimming is enabled.The reason was that the IL linker removed the
FirstChanceExceptionEventArgsconstructor since there's no reference to it in the app code. However the mono runtime tries to create it from native code. To fix this we added code to preserve the constructor.There are workarounds so this isn't critical for MAUI release.
Testing
Manual testing, made sure the
FirstChanceExceptionEventArgsconstructor is preserved when the app subscribes to theAppDomain.CurrentDomain.FirstChanceExceptionevent and trimmed when it doesn't.Risk
Low.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.