Improve performance of test partitioning #68172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have noticed a perf bug I made as part of the refactoring for merged test wrapper support. When there are no merged wrappers available due to test filtering (using the test / dir / tree commands-line argument), %(MergedAssemblyParentFolders.Identity) expands to an empty string at line 397 and AllRunnablePaths effectively search the entire HDD for tests to remove. In my case it reduced the running time of GetListOfTestCmds from 23 minutes to 3 milliseconds. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsI have noticed a perf bug I made as part of the refactoring for Thanks Tomas /cc @dotnet/runtime-infrastructure
|
jkoritzinsky
approved these changes
Apr 18, 2022
|
Known infra issue on Windows arm64 is unrelated to this change, merging in. |
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
I have noticed a perf bug I made as part of the refactoring for merged test wrapper support. When there are no merged wrappers available due to test filtering (using the test / dir / tree commands-line argument), %(MergedAssemblyParentFolders.Identity) expands to an empty string at line 397 and AllRunnablePaths effectively search the entire HDD for tests to remove. In my case it reduced the running time of GetListOfTestCmds from 23 minutes to 3 milliseconds. Thanks Tomas
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed a perf bug I made as part of the refactoring for
merged test wrapper support. When there are no merged wrappers
available due to test filtering (using the test / dir / tree
commands-line argument), %(MergedAssemblyParentFolders.Identity)
expands to an empty string at line 397 and AllRunnablePaths
effectively search the entire HDD for tests to remove. In my
case it reduced the running time of GetListOfTestCmds from 23
minutes to 3 milliseconds.
Thanks
Tomas
/cc @dotnet/runtime-infrastructure