Code

ConfigurationBinder handles ISet<>#68133

Code

Merged

tarekgh merged 28 commits intodotnet:maindotnet/runtime:mainfrom SteveDunn:configbinder-isetSteveDunn/runtime:configbinder-isetCopy head branch name to clipboardJul 19, 2022

+1,030-93

Commits

Commits on Jul 18, 2022

• First pass

  SteveDunn

  committed
  871166c

  Copy full SHA for 871166c

• Remove commented code

  SteveDunn

  committed
  3fe8714

  Copy full SHA for 3fe8714

• Support IReadOnlySet. Refactor out method that determines most suitable type for collections that are already specified in the destination.

  SteveDunn

  committed
  65ea989

  Copy full SHA for 65ea989

• Handles ISet after rebase. Still to do IReadOnlySet

  SteveDunn

  committed
  c2d1038

  Copy full SHA for c2d1038

• Add support back for IReadOnlySet

  SteveDunn

  committed
  2613c44

  Copy full SHA for 2613c44

• PR feedback - pre-allocate just one array instead of many allocations in a loop

  SteveDunn

  committed
  b377ac1

  Copy full SHA for b377ac1

• All tests pass.

  SteveDunn

  committed
  10e6238

  Copy full SHA for 10e6238

• Tidy

  SteveDunn

  committed
  c8e7b60

  Copy full SHA for c8e7b60

• Skips custom sets

  SteveDunn

  committed
  ef33f6f

  Copy full SHA for ef33f6f

• Strip out unused code

  SteveDunn

  committed
  accbc13

  Copy full SHA for accbc13

• Tidy up and remove dead code.

  SteveDunn

  committed
  92afd9a

  Copy full SHA for 92afd9a

• Tidy up tests

  SteveDunn

  committed
  3687886

  Copy full SHA for 3687886

• Tidy up comments

  SteveDunn

  committed
  3c65aa4

  Copy full SHA for 3c65aa4

• Copy over @halter73's changes

  SteveDunn

  committed
  ee0b40b

  Copy full SHA for ee0b40b

• Copy over @halter73's changes

  SteveDunn

  committed
  6b6f6cd

  Copy full SHA for 6b6f6cd

• Copy over @halter73's changes

  SteveDunn

  committed
  6efcd54

  Copy full SHA for 6efcd54

• Added restrictions and some tests for set keys being string/enum only

  SteveDunn

  committed
  3454939

  Copy full SHA for 3454939

• PR feedback re. preprocessor directive

  SteveDunn

  committed
  686192e

  Copy full SHA for 686192e

• Started on instantiated dictionary feedback

  SteveDunn

  committed
  b9a9f3a

  Copy full SHA for b9a9f3a

• First pass at cloning dictionary<,>

  SteveDunn

  committed
  32609c8

  Copy full SHA for 32609c8

• Can now bind (overwrite) to an existing concrete dictionary

  SteveDunn

  committed
  1310ebd

  Copy full SHA for 1310ebd

• Refactor out common code for binding to existing dictionary. Added tests.

  SteveDunn

  committed
  da49d5b

  Copy full SHA for da49d5b

• Comments and more tests

  SteveDunn

  committed
  3f359f4

  Copy full SHA for 3f359f4

• Add explicit (separate) test for binding to non-instantiated IReadOnlyDictionary

  SteveDunn

  committed
  c015c01

  Copy full SHA for c015c01

• PR feedback - add tests

  SteveDunn

  committed
  93cf8c0

  Copy full SHA for 93cf8c0

• PR feedback: introdcue variable for `typeIsADictionaryInterface'

  SteveDunn

  committed
  1667f86

  Copy full SHA for 1667f86

• PR feedback

  SteveDunn

  committed
  ca1defe

  Copy full SHA for ca1defe

• Fix rebase issues

  SteveDunn

  committed
  72be954

  Copy full SHA for 72be954