Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: Improve getStringLiteral for dynamic context #68055

Merged
merged 14 commits into from
Apr 17, 2022
Merged

vm: Improve getStringLiteral for dynamic context #68055

merged 14 commits into from
Apr 17, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 14, 2022

Improve getStringLiteral API to return string content for dynamic context.

Closes #67956
Fixes perf regression - #65222 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 14, 2022
@ghost ghost assigned EgorBo Apr 14, 2022
@ghost
Copy link

ghost commented Apr 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Improve getStringLiteral API to return string content for dynamic context.

Closes #67956
Fixes perf regression - #65222 (comment)

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

am11
am11 reviewed Apr 15, 2022
View reviewed changes
@EgorBo
Copy link
Member Author

EgorBo commented Apr 15, 2022

@jkotas @MichalStrehovsky does it look good now?

jkotas
jkotas reviewed Apr 15, 2022
View reviewed changes
jkotas
jkotas reviewed Apr 15, 2022
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Apr 16, 2022

LGTM otherwise

@EgorBo EgorBo merged commit a39ddca into dotnet:main Apr 17, 2022
@EgorBo EgorBo deleted the fix-getstringliteral-dynamic branch April 17, 2022 09:59
@jakobbotsch jakobbotsch mentioned this pull request Apr 18, 2022
Closed
@kunalspathak kunalspathak mentioned this pull request Apr 21, 2022
Closed
This was referenced Apr 22, 2022
Closed
Closed
Closed
@dakersnar
Copy link
Contributor

Windows x86 improvements: dotnet/perf-autofiling-issues#4712

@dakersnar dakersnar mentioned this pull request Apr 28, 2022
Closed
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Apr 29, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@jkotas jkotas jkotas approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve vm's getStringLiteral for dynamic context
5 participants
@EgorBo @jkotas @dakersnar @am11 @MichalStrehovsky