Ensure Sync stream serialization is handling IAsyncEnumerable correctly #67035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsFix #66687. Also enables small buffer async tests for collections.
|
krwq
reviewed
Mar 24, 2022
| @@ -25,7 +25,7 @@ public sealed override void Write(Utf8JsonWriter writer, T value, JsonSerializer | |||
| // Bridge from resumable to value converters. | |||
|
|
|||
| WriteStack state = default; | |||
| state.Initialize(typeof(T), options, supportContinuation: false); | |||
| state.Initialize(typeof(T), options, supportContinuation: false, supportAsync: false); | |||
There was a problem hiding this comment.
Agreed, but in this case it just mimics convention for the existing supportContinuation parameter. We can rename evertyhing at a future PR.
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…ly (dotnet#67035) * Fix dotnet#66687 * enable small buffer async tests for collections
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66687. Also enables small buffer async tests for collections.