Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create small constants while morphing cascading addition #66270

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Do not create small constants while morphing cascading addition #66270

merged 2 commits into from
Mar 7, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Mar 6, 2022 •
edited
Loading

Fixes #66269.

No diffs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 6, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 6, 2022
@ghost
Copy link

ghost commented Mar 6, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66269.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review March 6, 2022 23:06
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit 5ff9efa into dotnet:main Mar 7, 2022
@SingleAccretion SingleAccretion deleted the Constants-Are-Not-Small branch March 7, 2022 09:56
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Apr 1, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed 'type == genActualType(type)' during 'Morph - Global'
2 participants
@SingleAccretion @jakobbotsch