-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastMod for EEHashTable (Faster virtual generics) #65926
Conversation
In the long term we should experiment with a more lightweight caching scheme for virtual generics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@EgorBo
|
Ouch, sorry for that, I thought that job failed everywhere and merged, looking at it now |
@elinor-fung filed #66035 |
Improvement on alpine-x64 dotnet/perf-autofiling-issues#3977 |
Closes #65778
It was suggested to use a different data structure for
CORINFO_HELP_VIRTUAL_FUNC_PTR
but that is a more complicated change and I think this one worth having too anyway.Benchmark: