-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default method support to virtual statics #64717
Add default method support to virtual statics #64717
Conversation
…atic interface virtuals
- Enable use of "mono" as switch when building the overall test suite - On windows, copy coreclr.dll not libcoreclr.so
@vargaz When I run the new tests on Mono, they fail with crashes after 12 tests. However, we ALSO fail with a crash after 12 tests in the old test which hasn't been changed. When do we plan to fix this test suite for Mono? |
I've been waiting for the type system change part of #54063 but since it looks like it might not land anytime soon, I might just take the type system part, finish it, and run with it. Might not get to that soon either though. But it looks like NativeAOT has more urgency for that for .NET 7 than crossgen2 has. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed very nice and clean, thanks David! The expanded test set will be of immense help when stabilizing SVM resolution in Crossgen2 in the presence of default interface methods.
/azp list |
/azp run runtime-coreclr crossgen2 outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Running an outerloop crossgen test to make sure that the rather long new test names don't cause significant issues in our test suite. |
…hod_support_to_virtual_statics
/azp run runtime-coreclr crossgen2 outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/cc @SamMonoRT |
In addition, I've taken the liberty to enable running the coreclr test suite on Mono on Windows. It needed a small amount of fixup.