Fixes two logging source gen bugs - when using "in" or "ref" modifier / when dealing with constraints #64593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Supports usage of "in" modifier - Improves support for generic constraints Fixes dotnet#58550, dotnet#62644
|
Tagging subscribers to this area: @dotnet/area-extensions-logging |
maryamariyan
changed the title
stephentoub
reviewed
Feb 1, 2022
...ons/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs
Outdated
Show resolved
Hide resolved
maryamariyan
changed the title
ericstj
reviewed
Feb 1, 2022
.../tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/ConstaintsTestExtensions.cs
Show resolved
Hide resolved
ericstj
reviewed
Feb 1, 2022
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
Show resolved
Hide resolved
tarekgh
reviewed
Feb 1, 2022
src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Emitter.cs
Show resolved
Hide resolved
elinor-fung
reviewed
Feb 1, 2022
.../tests/Microsoft.Extensions.Logging.Generators.Tests/TestClasses/ConstaintsTestExtensions.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Feb 1, 2022
eerhardt
approved these changes
Feb 1, 2022
elinor-fung
approved these changes
Feb 1, 2022
| @@ -86,7 +86,7 @@ namespace {lc.Namespace} | |||
| // loop until you find top level nested class | |||
| while (parent != null) | |||
| { | |||
| parentClasses.Add($"partial {parent.Keyword} {parent.Name} {parent.Constraints}"); | |||
| parentClasses.Add($"partial {parent.Keyword} {parent.Name} "); | |||
There was a problem hiding this comment.
nit: you can probably remove the trailing space too
There was a problem hiding this comment.
No, but will create it UPDATE: created #64665 |
This was referenced Feb 2, 2022
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1786699177 |
2 tasks
2 tasks
3 tasks
maryamariyan
added a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 4, 2022
… / when dealing with constraints (dotnet#64593) * Fixes some logging source gen bugs: - Supports usage of "in" modifier - Improves support for generic constraints Fixes dotnet#58550, dotnet#62644 * Apply PR feedback * Add another test
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inorrefmodifierFixes #58550, #62644