-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some test for FreeBSD #64426
fix some test for FreeBSD #64426
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailscontributes to #14537 and fixes some test sets reported as broken:
Since this does not seems critical, I simply disabled and
and the test was failing because it would get 2 instead of 1. Since the value is really not meaningful as counter I adjusted the test to expect non-zero value. (e.g true vs 0 -> false) And the All the networking tests are passing now
|
I am still getting a hang in |
I did more runs and I see occasional failure @Thefrank. So I disabled that test as well. |
@@ -359,6 +359,7 @@ public static IEnumerable<object[]> InvalidPrefix_TestData() | |||
|
|||
[Theory] | |||
[MemberData(nameof(InvalidPrefix_TestData))] | |||
[SkipOnPlatform(TestPlatforms.FreeBSD, "FreeBSD accepts some as valid and test hangs")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"accepts some as valid"... some what? I'm not understanding the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some items from InvalidPrefix_TestData
. http://192./
for example. I did not dig deeper why that is happening.
contributes to #14537 and fixes some test sets reported as broken:
I just disabled failing tests. When the code does not throws as expected whole set hangs. I see no reason investing into HttpListener
I opened separate issue for tracing and disabled two tests with ActiveIssue. We are lacking ability to get listening connections at the moment.
Adjusted expectation around Alerts - We use OpenSSL so the behavior is same as Linux.
This is the curious one. The test expects we would throw when sending to broadcast without SO_BROADCAST.
The documentation has references to it as well but that is not what I see happening
Since this does not seems critical, I simply disabled
Datagram_UDP_AccessDenied_Throws_DoesNotBind
and
Get_AcceptConnection_Succeeds
was expecting value of one. The man page did mentioned something about boolean and the implementation really just returns the flag if set:and the test was failing because it would get 2 instead of 1. Since the value is really not meaningful as counter I adjusted the test to expect non-zero value. (e.g true vs 0 -> false)
And the
SkipTestException
in GetSetRawSocketOption_Roundtrips makes the test fail if we do not useConditionalTheory
attribute. Since the fix was simple, I also added values for FreeBSDAll the networking tests are passing now