-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector256.IsHardwareAccelerated to return true only on AVX2 #64345
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
@@ -664,7 +664,7 @@ static bool ValidateVector256() | |||
{ | |||
bool succeeded = true; | |||
|
|||
if (Avx.IsSupported) | |||
if (Avx2.IsSupported) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EgorBo, the ValidateVector128
case needs to be updated above (from SSE to SSE2), to ensure that it will pass the outerloop ISA jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannergooding oops :| thanks, forgot to kick outerloop jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a known failure there still that I have to fix, so probably good that you didn't...
I should hopefully get that resolved today (its likewise related to a mischeck when SSE2
but not SSE
is disabled)
Closes #64309
Vector128.IsHardwareAccelerated
is fine with SSE2