Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector256.IsHardwareAccelerated to return true only on AVX2 #64345

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 26, 2022

Closes #64309

Vector128.IsHardwareAccelerated is fine with SSE2

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned EgorBo Jan 26, 2022
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@EgorBo
Copy link
Member Author

EgorBo commented Jan 27, 2022

System.Security.Cryptography.Tests fails everywhere thus unrelated

@EgorBo EgorBo merged commit 19291cc into dotnet:main Jan 27, 2022
@@ -664,7 +664,7 @@ static bool ValidateVector256()
{
bool succeeded = true;

if (Avx.IsSupported)
if (Avx2.IsSupported)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorBo, the ValidateVector128 case needs to be updated above (from SSE to SSE2), to ensure that it will pass the outerloop ISA jobs

Copy link
Member Author

@EgorBo EgorBo Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding oops :| thanks, forgot to kick outerloop jobs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a known failure there still that I have to fix, so probably good that you didn't...

I should hopefully get that resolved today (its likewise related to a mischeck when SSE2 but not SSE is disabled)

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update when Vector256<T>.IsHardwareAccelerated returns true
4 participants