Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete __SkipCrossgenFramework #63390

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

MichalStrehovsky
Copy link
Member

This has been unused ever since crossgenning framework moved to build.proj.

This has been unused ever since crossgenning framework moved to build.proj.
@ghost
Copy link

ghost commented Jan 5, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This has been unused ever since crossgenning framework moved to build.proj.

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up! I believe we're still able to skip crossgenning the framework by not specifying the crossgen2 / composite option to src\tests\build.cmd/sh so I guess this was just a legacy duplicate.

@jkotas jkotas merged commit 70065c1 into dotnet:main Jan 5, 2022
@MichalStrehovsky MichalStrehovsky deleted the skipcrossfx branch January 5, 2022 21:09
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants