Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Implementation]: DirectoryInfo.CopyTo / Directory.Copy #62375
[API Implementation]: DirectoryInfo.CopyTo / Directory.Copy #62375
Changes from 4 commits
2e6ebb0
0367de3
3eb9974
c019831
05a335c
e2a24ca
fe409d6
d4ead0f
3021503
815aca7
0298d60
5a38e66
0a1820d
4d9da94
fad47d0
20404b4
f430130
4bf462f
cdca890
d207673
69e7a3b
727997f
ce89d2d
7952a77
42625af
d8b32cc
480ea54
518a734
6963cb0
d617da8
04843bd
08db652
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename this method to
CopyDirectory
, and addfull
int the argument names to indicate the caller must provide the method with full paths.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's probably more to catch than IOExceptions here, isn't it? e.g DirectoryNotFoundException, UnauthorizedAccessException (see the Exceptions section in https://docs.microsoft.com/en-us/dotnet/api/system.io.directory.enumeratedirectories?view=net-6.0.).
Or maybe we should catch all of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now updated this (See #62375 (comment)). I'm not sure if I have the right behavior for the exceptions though.
Can you take a look if there is anything that needs to be narrowed down.