Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Work around System.Diagnostics.Tests.StopwatchTests.GetTimestamp failure #62290

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

radical
Copy link
Member

@radical radical commented Dec 2, 2021

.. by sleeping for 5ms on wasm, instead of 1ms. Thanks to @danmoseley for the suggestion.

Issue: #62021

@radical radical added the arch-wasm WebAssembly architecture label Dec 2, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Dec 2, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #62021

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@danmoseley
Copy link
Member

Why disable it? just add some slop for Browser only, such as 5ms. That will be higher value than having no coverage and it may be the long term fix.

@radical
Copy link
Member Author

radical commented Dec 2, 2021

Why disable it? just add some slop for Browser only, such as 5ms. That will be higher value than having no coverage and it may be the long term fix.

I'm fine with either. Just trying to avoid the test failures on CI runs ;)

If that sounds acceptable to others, then I can update the PR.

@danmoseley
Copy link
Member

I doubt they'd object 😺

@radical
Copy link
Member Author

radical commented Dec 2, 2021

I doubt they'd object 😺

heh sorry, I was being lazy, and trying to avoid reading the details of the issue! I'll update the PR :)

@radical radical changed the title [wasm] Disable System.Diagnostics.Tests.StopwatchTests.GetTimestamp [wasm] Work around System.Diagnostics.Tests.StopwatchTests.GetTimestamp failure Dec 2, 2021
@radical
Copy link
Member Author

radical commented Dec 2, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Dec 3, 2021

Wasm runtime test failure is #62303 .

Others are unrelated failures in runtime-staging.

@radical radical merged commit 7cb9424 into dotnet:main Dec 3, 2021
@radical radical deleted the disable-stopwatch-test branch December 3, 2021 04:31
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants