-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Work around System.Diagnostics.Tests.StopwatchTests.GetTimestamp
failure
#62290
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Why disable it? just add some slop for Browser only, such as 5ms. That will be higher value than having no coverage and it may be the long term fix. |
I'm fine with either. Just trying to avoid the test failures on CI runs ;) If that sounds acceptable to others, then I can update the PR. |
I doubt they'd object 😺 |
heh sorry, I was being lazy, and trying to avoid reading the details of the issue! I'll update the PR :) |
System.Diagnostics.Tests.StopwatchTests.GetTimestamp
failure
/azp run runtime-manual |
Azure Pipelines successfully started running 1 pipeline(s). |
Wasm runtime test failure is #62303 . Others are unrelated failures in runtime-staging. |
.. by sleeping for 5ms on wasm, instead of 1ms. Thanks to @danmoseley for the suggestion.
Issue: #62021