Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for referencing the DllImport source generator now that we use the RTM sdk. #62156

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Nov 29, 2021

This should stop all of the data races from being a problem as we're building through normal ProjectReferences now

Fixes #62028
Fixes #61687

@ghost
Copy link

ghost commented Nov 29, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This should stop all of the data races from being a problem as we're building through normal ProjectReferences now

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure

Milestone: -

eng/Versions.props Outdated Show resolved Hide resolved
Co-authored-by: Andy Gocke <[email protected]>
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky
Copy link
Member Author

Regex test failure is unrelated. Merging to unblock CI.

@jkoritzinsky jkoritzinsky merged commit 84b55d9 into dotnet:main Nov 30, 2021
@jkoritzinsky jkoritzinsky deleted the remove-dllimport-workarounds branch November 30, 2021 21:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants