Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Use cross origin policy headers #62016

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 24, 2021

Use xharness arg --web-server-use-cop to set cross origin policy headers

Cross-Origin-Embedder-Policy: require-corp
Cross-Origin-Opener-Policy: same-origin

In Chrome 92 SharedArrayBuffer was disabled due to a vulnerability. To enable it site must be cross-origin isolated (by COEP and COOP headers). More info at https://developer.chrome.com/blog/enabling-shared-array-buffer/.

Fixes #61945

@maraf maraf added this to the 7.0.0 milestone Nov 24, 2021
@ghost
Copy link

ghost commented Nov 24, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Use xharness arg --web-server-use-cop to set cross origin policy headers

Cross-Origin-Embedder-Policy: require-corp
Cross-Origin-Opener-Policy: same-origin

Fixes #61945

Author: maraf
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 7.0.0

@pavelsavara pavelsavara requested a review from premun November 24, 2021 15:09
@radical
Copy link
Member

radical commented Nov 24, 2021

@maraf could you add a reasoning for the change? @kg had pointed to https://developer.chrome.com/blog/enabling-shared-array-buffer/ , and that would be useful to add to the PR description too.

@maraf
Copy link
Member Author

maraf commented Nov 25, 2021

There is a misalignment between Xharness and Arcade versions.
This will be solved by #61668.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] JS Interop tests failing with latest chrome - JavaScript host object 'SharedArrayBuffer' not found
4 participants