Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Follow up changes for 61590 (#61670) #61787

Conversation

MaximLipnin
Copy link
Contributor

Backport of #61670 to release/6.0

/cc @MaximLipnin @steveisok

Customer Impact

  • Added a set of UnsupportedOSPlatform annotations to System.Diagnostics.Process API's, which previously used the libproc private Apple API.
  • skipped the respective S.D.P. tests as those API's throw PNSE now

Testing

Manual testing

Risk

Low.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Nov 18, 2021

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #61670 to release/6.0

/cc @MaximLipnin @steveisok

Customer Impact

  • Added a set of UnsupportedOSPlatform annotations to System.Diagnostics.Process API's, which previously used the libproc private Apple API.
  • skipped the respective S.D.P. tests as those API's throw PNSE now

Testing

Manual testing

Risk

Low.

Author: MaximLipnin
Assignees: -
Labels:

area-System.Diagnostics.Process, new-api-needs-documentation

Milestone: -

@MaximLipnin
Copy link
Contributor Author

Closing it as it'll be combined with #61659

@MaximLipnin MaximLipnin deleted the backport-pr61670-to-release-6.0 branch November 18, 2021 19:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant