Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OneLoc build temporarily #61658

Closed
wants to merge 1 commit into from
Closed

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Nov 16, 2021

It's currently blocking the official build.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@hoyosjs hoyosjs requested review from a team and removed request for a team November 16, 2021 08:18
@ericstj ericstj requested a review from jonfortescue November 16, 2021 18:28
@ericstj
Copy link
Member

ericstj commented Nov 16, 2021

Can we just close the PR it's trying to update instead?

@ericstj
Copy link
Member

ericstj commented Nov 16, 2021

I see that's what @mmitche did here: #61274

@jonfortescue
Copy link
Contributor

Yeah, it looks like it has since started working just fine again: #61680

@safern
Copy link
Member

safern commented Nov 16, 2021

Yes, we can close this PR now. Thanks @hoyosjs

@safern safern closed this Nov 16, 2021
@safern safern deleted the juhoyosa/disable-oneloc branch November 16, 2021 18:34
@ericstj
Copy link
Member

ericstj commented Nov 16, 2021

So this probably happened because @safern's PR changed the files here : #61489

Some thoughts on process:

  1. When a loc PR comes in, merge so long as it's green and doesn't break the product.
  2. Ideally this should be made easier by LOC system not churning the PR with empty commits.
  3. If commits are required to make the LOC PR green or not break the product, those commits should be made to the LOC PR. If the LOC system sees a commit that is not itself as head of the PR branch it should not touch that branch and either just create a new PR, or skip creating a PR.
  4. If a LOC PR has translation issues that don't break the product we should merge the LOC PR with those and either file issues, or open a PR to address them.

4 is something we can do now. I think 2 & 3 require changes to the loc build process.

@jonfortescue
Copy link
Contributor

@ericstj I've brought up 2 & 3 with the loc team so hopefully those get rolled out soon.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants