Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] renames and cleanup before modularization #61596

Merged
merged 10 commits into from
Nov 17, 2021
Merged

[wasm] renames and cleanup before modularization #61596

merged 10 commits into from
Nov 17, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 15, 2021 •
edited
Loading

  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
  • moved dotnet IFFE out of emcc Closure compiled section and re-enabled terser() and ES2018 target.

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Nov 15, 2021
@pavelsavara pavelsavara added this to the 7.0.0 milestone Nov 15, 2021
@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
Author: pavelsavara
Assignees: -
Labels:

arch-wasm
Milestone: 7.0.0

@kg
Copy link
Member

kg commented Nov 15, 2021

Happy to finally rename runtime to something reasonable

@pavelsavara pavelsavara requested a review from thaystg November 15, 2021 22:21
@pavelsavara
- no imports from outer scope
304a8b6 
- move dotnet to -extern-pre-js
- re-enable JS minification
- rename main javaScript files to main.js and test-main.js
- sample and test script cleanup
- rename set_exit_code method
- rewrite test start as async method
- improve script loading via script element on page in test
- use BINDING.bind_static_method instead of INTERNAL where possible
- better .d.ts exports
- formatted html files
@pavelsavara pavelsavara marked this pull request as ready for review November 16, 2021 06:12
@pavelsavara
Copy link
Member Author

This passed CI tests with full matrix. I also tested debugger unit tests and debugger in Blazor app manually.

kg
kg reviewed Nov 16, 2021
View reviewed changes
src/mono/wasm/test-main.js Outdated Show resolved Hide resolved
maraf
maraf reviewed Nov 16, 2021
View reviewed changes
src/mono/wasm/test-main.js Show resolved Hide resolved
src/mono/wasm/runtime/exports.ts Show resolved Hide resolved
@pavelsavara
feedback from @kg and @maraf
9b14f6c 
- renamed modules.ts to imports.ts which makes more sense
- improved error propagation
- renamed __initializeImportsAndExports
@pavelsavara
observe exit behavior
ba2bd5d
@thaystg
Copy link
Member

thaystg commented Nov 16, 2021

Debugger tests -> passing.
Debug a Blazor App -> working.

This was referenced Nov 16, 2021
Closed
Closed
@pavelsavara pavelsavara merged commit da0e0f7 into dotnet:main Nov 17, 2021
pavelsavara added a commit to pavelsavara/BenchmarkDotNet that referenced this pull request Nov 19, 2021
@pavelsavara
fix perf after renames in dotnet/runtime#61596
f80983b
@pavelsavara pavelsavara mentioned this pull request Nov 19, 2021
Merged
adamsitnik pushed a commit to dotnet/BenchmarkDotNet that referenced this pull request Nov 19, 2021
@pavelsavara
[wasm] fix perf after test renames (#1846)
db0a88a 
* fix perf after renames in dotnet/runtime#61596
@pavelsavara pavelsavara deleted the wasm_modularization8 branch November 20, 2021 19:38
@AndyAyersMS AndyAyersMS mentioned this pull request Nov 22, 2021
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf left review comments

@kg kg kg approved these changes

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@thaystg thaystg Awaiting requested review from thaystg

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelsavara @kg @thaystg @maraf