Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: test JIT assert on superpmi replay/asmdiffs pipelines #61477

Closed
wants to merge 1 commit into from

Conversation

BruceForstall
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 11, 2021
@ghost
Copy link

ghost commented Nov 11, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr superpmi-replay

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Member Author

cc @kunalspathak

I want to see what our current replay/asmdiffs pipelines do for a JIT assert during SPMI replay

@BruceForstall
Copy link
Member Author

For asmdiffs, the Extensions page shows "No diffs found", as expected. If you don't dig deeper, you wouldn't see the errors.

The asmdiffs jobs do have errors. However, they also have errors currently if there is MISSING data, so people might start ignoring the errors. If you look at the console logs for each failure (e.g., drilling in from this page), you see failures like:

ERROR: Exception thrown: DebugBreak or AV Exception 123
ERROR: Method 1 of size 86 failed to load and compile correctly by JIT2.
ERROR: method 1 is missing a compileResult, cannot do diffing
ISSUE: <ASSERT> D:\a\_work\1\s\src\coreclr\jit\compiler.cpp (1782) - info.compMethodSuperPMIIndex != 1

@kunalspathak
Copy link
Member

If you look at the console logs for each failure (e.g., drilling in from this page), you see failures like:

Right, it is very easy to get these errors ignored. If we can scan them and report it back to the extension under a separate section, that might help.

@BruceForstall
Copy link
Member Author

With the replay pipeline, you need to dig into the log files. The jobs do show as failed.

@kunalspathak Is there an equivalent of #61483 for the replay pipeline? Maybe some kind of summary output to an "Extensions" tab would make sense here, also?

@BruceForstall BruceForstall deleted the TestAssert branch November 11, 2021 22:32
@kunalspathak
Copy link
Member

We don't have a tracking issue, but should probably do it when we pursue #61483

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants