[wasm] Add task marshaling tests. #61324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add various tests for marshaling task to JavaScript promise. - Sync and async. - Generic and non-generic. - Successful and failed.
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAdd various tests for marshaling task to JavaScript promise.
@pavelsavara @kg Do you have some ideas for additional scenarios to test?
|
|
Looks good. I'd add a test for |
pavelsavara
reviewed
Nov 9, 2021
...e.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/MarshalTests.cs
Outdated
Show resolved
Hide resolved
…ons as if the feature is implemented.
maraf
force-pushed
the
wasm_task_marshal_tests
branch
from
6101d42 to
5f30ce3
Compare
|
I have added the same bunch of tests for ValueTasks as for Tasks, as I'm expecting the marshaling implementation will be different. Let me know if it's ok or we don't need all of them. |
pavelsavara
approved these changes
Nov 10, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various tests for marshaling task to JavaScript promise.
These tests replace those added in the #47640.
@pavelsavara @kg Do you have some ideas for additional scenarios to test?