-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1471900 #61274
Closed
Closed
Changes from 73 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
cc48d9d
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot ee1a955
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 2ea8785
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 229b837
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 3ef1e5e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 80c842f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 38f4196
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 6b2bcc5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 414c8c5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 3142aab
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 0c58e43
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot a744436
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot d9c52e5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 222db2a
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot fd8f469
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot ce40629
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 29b430f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot aa7c72d
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot dc255bb
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot dc1057a
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot a169795
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot e5d8d25
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 6f13c11
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot b1877cb
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot f68b99e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot bb3a3bf
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 7a93e39
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot eb97f67
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 37889c8
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot ae769b5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 9bbee7f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 9b52d7c
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 4fec88f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot cd748a4
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot ec00c6e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 223a12e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 612f1ba
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 5fb7e1b
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 8d02c37
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 539c098
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot de83b21
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot f9b4987
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 3c77c18
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot a2ab03f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 3052ed6
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 2b8619c
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot aead083
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 6f4178e
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot da518f4
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 2da9eb6
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot c153945
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 8febf34
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 1f012ed
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot bec13d4
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot cc11c9f
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 6de66ee
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 0459de2
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 774000c
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 1085231
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot fa658db
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot fd8f817
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 98aafd8
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 8a9830d
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 2aa3931
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 00484de
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot fe80469
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 6e627ed
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 700e926
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot fb8a9f7
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot bd30c22
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 73bb389
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot c8463ec
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot c461c0c
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 835b9f4
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 74f46e5
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 2cbe183
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot af5bf29
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 97af1ba
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 67cfc77
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot a3b8055
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot edf3a36
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 600ed54
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot 3cea02d
Localized file check-in by OneLocBuild Task: Build definition ID 679:…
dotnet-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,7 +194,7 @@ | |
</trans-unit> | ||
<trans-unit id="NotSupported_NonBacktrackingAndReplacementsWithSubstitutionsOfGroups"> | ||
<source>Regex replacements with substitutions of groups are not supported with RegexOptions.NonBacktracking.</source> | ||
<target state="new">Regex replacements with substitutions of groups are not supported with RegexOptions.NonBacktracking.</target> | ||
<target state="translated">Substituições de regex com substituições de grupos não são suportadas com RegexOptions.Nonbacktracking.</target> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one changed as well. |
||
<note /> | ||
</trans-unit> | ||
<trans-unit id="NotSupported_ReadOnlyCollection"> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should've
RegexOptions.NonBacktracking
be an href so that is not localized?cc: @ericstj @stephentoub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can just reject that localization by changing the state? Perhaps we should add a note when doing so that
RegexOptions.NonBacktracking
should not be localized. Let me ping @cristianosuzuki77 and @jonfortescue to see if they know.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you can add a comment to the source resx (which will be carried through to the xlf) just saying "do not localize this"; that's usually the best way to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought. I'll put up a PR to fix those. Thanks!