-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][mobile] Enable diagnostic_tracing for mobile runtime tests #60879
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
885c4bc
to
91222d3
Compare
With Steve's latest change to reduce the amount of runtime tests running per PR, I believe that all runtime tests running on mobile targets have been moved to rolling build. You would need to modify the runtime.yml and/or runtime-stage.yml files to validate your change here. |
d967a78
to
ecdf812
Compare
/azp run runtime |
Azure Pipelines failed to run 1 pipeline(s). |
ecdf812
to
2f5dce9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this builds and pass, could we also validate that the tests are actually executed on CI as expected?
cd09c58
to
cbf9611
Compare
/azp run runtime-manual |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @tommcdon Issue DetailsThis PR looks to stand-up diagnostics tests for mobile, specifically targeting Android. Diagnostics runtime components have been made compatible for mobile platforms, and here, they will be tested and integrated. The following are changes made: With a goal of emulating the diagnostics tracing tests on mono desktop, the following tests now pass locally. eventlistenereventlistener eventcountereventcounter eventactivityidcontroleventactivityidcontrol eventpipeprocessinfo The rest of the eventpipe tests require a little more effort to replace legacy RuntimeClient code and will be tackled in a follow up PR. buffersize, eventsourceerror, bigevent, name_config_with_pid, reverse, reverseouter, pauseonstart, diagnosticport, processenvironment
|
a7bb745
to
ec86c65
Compare
Reenables eventactivityidcontrol now that diagnostics_tracing runtime component is included
ec86c65
to
56907eb
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
4ae52d5
to
3b8ef23
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Can I get another look over this PR @lateralusX, all the tests in the updated PR description are passing on CI. |
@mdh1418 How did you verify that the enabled tests now runs on Android on CI? Are we running the tests on all Android platforms currently tested on CI? I believe this looks overall good, great to get the test running on mobile platforms. |
I looked through the Android runtime tests lane on this PR's CI checks
However, I only checked that one lane so far |
LGTM! |
… desktop mono" This reverts commit 3b8ef23.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
@mdh1418 Can you verify that the last config in this PR now runs the test on Android? If so I believe this is good to go! |
@lateralusX Just checked the lane |
Before merging this, dotnet/diagnostics needs to be updated to accept a string parameter to the DiagnosticsClient constructor and allow for TCPIP connection. After which,
MicrosoftDiagnosticsNETCoreClientVersion
can be bumped. The tests work locally because a modified manual build of dotnet/diagnostics was used.This PR looks to stand-up diagnostics tests for mobile, specifically targeting Android. Diagnostics runtime components have been made compatible for mobile platforms, and here, they will be tested and integrated.
The following are changes made:
Includes
diagnostics_tracing
runtime components inBuildAndroidApp
Sets the
DiagnosticsPorts
to default to127.0.0.1:9000,nosuspend,listen
Fix IpcUtils
GetStandardTransport
to set up TCP/IP connection on Android, connecting to default DiagnosticsPortsFixes #52763
Disables
JitOptimizationSensitive
on Android for eventpipe testsWith a goal of emulating the diagnostics tracing tests on mono desktop, the following tests now pass locally.
eventlistener
eventlistener
eventcounter
eventcounter
pollingcounter
regression-46938
regression-25709
incrementingpollingcounter
runtimecounters
incrementingeventcounter
gh53564
eventactivityidcontrol
eventactivityidcontrol
Of the eventpipe tests, 5 of them will be enabled in a separate PR, and the rest require a significant modification to allow Android to run multiple apps at a time, specifically to allow for RunSubprocess in IpcUtils to work.
name_config_with_pid, reverse, reverseouter, pauseonstart, diagnosticport, processenvironment