-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] <EnablePreviewFeatures> for HttpStress #60682
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #59410 to release/6.0 /cc @antonfirsov Customer ImpactTestingRisk
|
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
@antonfirsov no special approval required to commit this. However, there's a cut off in this branch for 6.0 GA at 4pm PST Friday. After that the branch likely needs to hold all changes for a bit. |
@danmoseley In that case it would be really important to merge this and #60723 before that deadline. |
@antonfirsov would it make sense to just hold this and the other one until the branch opens again for 6.0.1, next month? If it's just enabling more testing, and won't make the last build tomorrow any better? We'll no doubt be taking changes into this branch for tests and such things for the full 3 years that 6.0 will be in support. tomorrow is just the cutoff for 6.0.0. |
Let's wait until branch opens for 6.0.1 If you need to do stress testing eg of the latest msquic please do so in main or locally until then |
Removing NO MERGE as it is now ready for merge into 6.0 servicing. @danmoseley does it need Approval label to be merged? Or how does it work for test-only changes? |
@karelz did you close this on purpose? Is there something that prevents us merging this? |
Nope, that was a mistake, sorry and thanks for catching it. |
@danmoseley ping? |
Oops, missed this. No approval needed for test-only changes. As long as the branch is open. |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
@danmoseley what is the process for getting this and #60723 merged? Should we apply some label, or ping some people? Note that both PR-s are needed to fully fix stress runs. |
Just ask @safern whether branch is open and he can merge it. Or else I can. |
The branch doesn't open until around December 17th once the branding changes are open. If this is approved we can add |
Ah this is a test only change. I'll merge it once the branch is open. |
I will look at all PRs based on target branch and milestone, so no worries, it will get merged. |
Backport of #59410 to release/6.0
/cc @antonfirsov
This is a test-only change fixing a build error in HttpStress so we can run stress tests again on
release/6.0
.Example failing build on the
release/6.0
branch:https://dev.azure.com/dnceng/public/_build/results?buildId=1429667&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=8ca65746-3bfa-57bf-9141-d805b5d39db5
Customer Impact
We need stress tests to assure the quality of the HTTP stack in .NET 6.0.
Testing
CI run should show if the build error is gone.
Risk
None.