Feature/get debug view value processing #60391
Conversation
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @maryamariyan, @safern Issue DetailsImplementation of API proposal #60065
|
| /// <summary> | ||
| /// Value of the current item | ||
| /// </summary> | ||
| public string Value { get; } |
There was a problem hiding this comment.
As mentioned in the issue comment value is non-nullable by definition of the IConfigurationProvider.
There was a problem hiding this comment.
It seems like it is conflicting with valueAndProvider.Value as that seems to be nullable and the build is failing because of that.
| @@ -69,7 +91,7 @@ public static string GetDebugView(this IConfigurationRoot root) | |||
| } | |||
| } | |||
|
|
|||
| return (null, null); | |||
| return ("", null); | |||
There was a problem hiding this comment.
Why are we changing this behavior?
|
Could you also update: https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.cs to add the new APIs? Here are instructions on how to do that: https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/updating-ref-source.md |
...libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs
Outdated
Show resolved
Hide resolved
Sure, will do. |
…src/ConfigurationRootExtensions.cs Co-authored-by: Santiago Fernandez Madero <[email protected]>
|
Hi @Andree643 - do you have an idea when the tests for the new API will be added? Let us know if you are interested in pushing this PR forward. |
Hi @eerhardt. I'll do my best to make it next week. I have some issues with building the solution and trying to resolve it. |
...braries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationDebugViewContext.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationDebugViewContext.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationDebugViewContext.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationDebugViewContext.cs
Outdated
Show resolved
Hide resolved
...libraries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationRootExtensions.cs
Outdated
Show resolved
Hide resolved
...braries/Microsoft.Extensions.Configuration.Abstractions/src/ConfigurationDebugViewContext.cs
Outdated
Show resolved
Hide resolved
…src/ConfigurationDebugViewContext.cs Docs update Co-authored-by: Eric Erhardt <[email protected]>
…src/ConfigurationDebugViewContext.cs Docs updateDocs update Co-authored-by: Eric Erhardt <[email protected]>
…src/ConfigurationDebugViewContext.cs Docs update Co-authored-by: Eric Erhardt <[email protected]>
…src/ConfigurationDebugViewContext.cs Docs update Co-authored-by: Eric Erhardt <[email protected]>
…src/ConfigurationRootExtensions.cs Docs update Co-authored-by: Eric Erhardt <[email protected]>
…src/ConfigurationDebugViewContext.cs Docs update Co-authored-by: Eric Erhardt <[email protected]>
Implementation of API proposal #60065 based on the changes proposed on the review
@safern