Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PerformanceCounter tests #60372

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Fix PerformanceCounter tests #60372

merged 2 commits into from
Oct 14, 2021

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Oct 13, 2021

Fix #45182
Fix #54943

This has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
Changed to use consistent variable names and actual names. Added asserts. Moved deleting categories to after disposing the counter. Add retries on deleting category. Fix a few comments.

Fix #29753

Change to use a counter less likely to be zero, and retry it.

@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #45182
Fix #54943

This has failed sporadically since these tests were written 4 years ago. On investigating I found that counter names and category names were intermingled, sometimes with the opposite names.
Changed to use consistent variable names and actual names. Added asserts. Moved deleting categories to after disposing the counter. Add retries on deleting category. Fix a few comments.

Author: danmoseley
Assignees: -
Labels:

area-System.Diagnostics.Tracing

Milestone: -

@danmoseley
Copy link
Member Author

@steveisok Build tvOSSimulator x64 Release AllSubsets_Mono timed out. It says after 3 hours, but I think it's because the build took 80 minutes.

@danmoseley danmoseley merged commit 1ebec9a into dotnet:main Oct 14, 2021
@danmoseley danmoseley deleted the fix.pc.tests branch October 14, 2021 04:44
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants