-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][test] BrowserHttpHandler stream large responses with SetBrowserResponseStreamingEnabled #60339
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIn order to be able to use This is unit test covering the customer scenario.
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
|
Doesn't seem like unrelated... I assume it's because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good, @pranavkm I wonder if this should be documented along with the option?
We have a quip about it on https://docs.microsoft.com/en-us/aspnet/core/blazor/call-web-api?view=aspnetcore-5.0&pivots=webassembly#httpclient-and-httprequestmessage-with-fetch-api-request-options-1.
|
@pranavkm I guess it would be great to also mention the |
In order to be able to use
WebAssemblyEnableStreamingResponse
option, the user should also setHttpCompletionOption.ResponseHeadersRead
so that the content would not be cached in memory.This is unit test covering the user scenario.
Fixes #60287