Add runtime.osx-arm64.runtime.native.System.IO.Ports proj file for pa… #60310
Conversation
…ckaging. Tested on actual osx-arm64 hardware, resulting package works correctly.
|
cc @jozkee |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFixes #59972 Customer Impact The native library for System.IO.Ports is current not built nor packaged for osx-arm64. The native library compiles cleanly and works correctly, but just isn't being built or packaged by the CI system. This change adds a package project to build/package it, which also adds it as a dependency to the meta runtime.native.System.IO.Ports package Testing Tested on actual Apple Silicon hardware with various serial devices. Since no current M1 device offers native serial ports, all testing was conducted with various USB devices that convert to or present as serial ports. Works correctly. Risk Low. The alternative is that there is no support at all. @ViktorHofer As requested
|
| <Import Project="runtime.native.System.IO.Ports.props" /> | ||
| <PropertyGroup> | ||
| <!-- TODO: Remove when the package shipped. --> | ||
| <DisablePackageBaselineValidation>true</DisablePackageBaselineValidation> |
There was a problem hiding this comment.
If this will be shipping in 6.0, do we still need this?
There was a problem hiding this comment.
Right now, yes, because it's not out in 6.0 and there isn't a nuget package the build process can pull down. Once it's actually in 6.0 and there's a package, then it can be removed.
|
Thanks, @SeanMollet! |
Fixes #59972
Customer Impact
The native library for System.IO.Ports is current not built nor packaged for osx-arm64. The native library compiles cleanly and works correctly, but just isn't being built or packaged by the CI system.
This change adds a package project to build/package it, which also adds it as a dependency to the meta runtime.native.System.IO.Ports package
Testing
Tested on actual Apple Silicon hardware with various serial devices. Since no current M1 device offers native serial ports, all testing was conducted with various USB devices that convert to or present as serial ports. Works correctly.
Risk
Low. The alternative is that there is no support at all.
@ViktorHofer As requested