-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring up full library test CI runs on iOS / tvOS devices #59503
Merged
Merged
Changes from 25 commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
64ef141
iOS AOT run w/ smaller test files
f7f87f7
Merge remote-tracking branch 'upstream/main' into test-zip-app
2e1ee0e
Bump timeout. Skip some tests that fail aot
336ec94
Merge remote-tracking branch 'upstream/main' into test-zip-app
9b29dc5
Print out space used and number of tests processed
4d678d5
Structure iOS test build to be able to run on helix
c42ef12
Get past race by enabling logging. Test passes on helix now
c69a4cd
Enable building on helix for other apple configurations
5324672
Integrate soft trimming
f052234
Update template to work with arcade changes
fe39010
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
d610108
Post merge with main adjustments
f7bb825
Bring up library tests on iOS / tvOS devices
f084ae9
Bump arcade / cleanup
17a2bb2
fix sim runs
e5d84bc
Build tweaks to fix running tests locally
2b2d451
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
c17c79e
Preserve more
7b4eda7
iOS arm64 runs take about 3 hours to complete. Use tvOS to get enough…
074f565
Figure out why tvos is taking forever uploading to helix.
abc79f2
Get sim lanes working. Move back to AggressiveTrimming
e5e136b
Save size by chopping native assets on the build machine and reassemb…
d8f104e
move binlog mv to sep step
5d9baa6
Make sure aot/process arguments are populated in the right spot
784cb6b
Remove trimming so that we can exclude the runtime pack from the arti…
c4c83fa
Fixup xml tests and debug/release local builds
9fbb6c7
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
62e907f
Don't use iOS device runs for now. Too little capacity
7b5ea33
Incorporate MonoTargetsTask
f90e00e
Skip generic math tests and additional test cleanup (paths)
650209b
Fix test
92259e2
Test fixup
5503e2b
Tweak
6023b0c
Set MONO_AOT_MODE environment variable to enable PlatformDetection.Is…
MaximLipnin 891d814
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
9038a81
Enable System.Runtime tests on iOS devices only. Disable some tests
3415de4
Merge remote-tracking branch 'origin/build-ios-tests-helix' into buil…
25574ed
Skip SRE and fix more tests
fe194f7
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
56b30b7
Merge branch 'main' into build-ios-tests-helix
MaximLipnin 2c4add6
Use a platform detection not a runtime feature
MaximLipnin 61a895c
Skip more tests that use sre
41a9f51
Make sure runtimeconfig.bin is generated.
8ef6c49
Wrong name for runtimeconfig
ddc2b64
tweak
b52675b
Skip some tests - bump work item timeout
633a8f1
Exclude JitInfoIsNotPopulated test when dynamic code is not supported
MaximLipnin 8653d81
Mark one test with an active issue on iOS
MaximLipnin b862450
Make sure the right test timeout is being passed along
2189974
Merge branch 'main' into build-ios-tests-helix
MaximLipnin aa50b69
Exclude more SRE tests
MaximLipnin d4f38c4
Exclude satellite assemblies from being AOT'd / System.Runtime.Loader…
f37b1cb
Merge remote-tracking branch 'origin/build-ios-tests-helix' into buil…
458fb58
Mark some serialization tests with an active issue on iOS/tvOS
MaximLipnin 637c061
Merge branch 'main' into build-ios-tests-helix
MaximLipnin a5263c1
Mark more serialization tests with an active issue
MaximLipnin 128238e
Mark some System.Threading.Channels.Tests with an active issue
MaximLipnin 8ce67d4
Skip more tests that use SRE
7a8f49c
Active issue and skip more tests
3b4c602
Skip more tests
e1d1748
Skip loader tests that assume assemblies are in as resource files
680c648
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
4af365a
Skip failing RegexCultureTests
926989d
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
0003313
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
2419858
Skip test suites that hang for now
055b85d
Restored fact that was mistakenly removed
81bd7fd
Feedback
1a3b910
Skip DllImportGenerator tests as they were failing
3c1babf
Search top level only for zip files
fdb81ff
Skip DllImportGenerator tests on all apple mobile platforms. Tweak p…
7d43598
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
e7d92da
Fix check specific platform check for catalyst
633dcf7
Remove old condition that was breaking unrelated projects
ef910cf
Feedback
4800f60
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
df80bf0
Fix process test introduced in https://github.com/dotnet/runtime/pull…
0fb5d0b
PR Feedback
6c3c9ee
Merge remote-tracking branch 'upstream/main' into build-ios-tests-helix
1b75f13
Apply smoke test setting to iOS & tvOS devices
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| XHARNESS_EXECUTION_DIR="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )" | ||
| XHARNESS_OUT="$XHARNESS_EXECUTION_DIR/xharness-output" | ||
|
|
||
| # RunCommands defined in tests.mobile.targets | ||
| [[RunCommands]] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, it looks like there are subsets of dependencies that are updated at the same time, is the general rule that we follow to update those of the same version or is it likely that only a few dependencies of version
7.0.0-beta.21472.6for example will be updated next time around?If Microsoft.DotNet.PackageTesting will always be updated with the dependencies at the top, does it make sense to move this to that group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The darc tool updates this file, so it's a black box to me :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually many dependencies come from 1 build - like Arcade produces about 12 packages that get consumed by runtime and then this build is "flown" to runtime which means all those package will get updated together.
You don't update this file manually - either the dependency PR makes that happen or you call
darc update-dependencieslocally so I wouldn't worry about it much. If someone does that in their branch like Steve has, it usually happens that main gets up-to-date before we close the PR and then Steve would just revert changes here. Also, Arcade has to be validated first before we can bump it in runtime so probably we wouldn't even let Steve bump it and wait for main to catch up.I don't understand how this file gets populated with new dependencies though, so no idea about the exact order. It's very probable that if you re-order this, it will get re-ordered back because it depends on some order in the maestro database. Or it will just stay how you set it. However, you will have a nasty conflict with whatever dependency PR is currently open.