Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Microsoft.IO.Redist. #58359

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Remove Microsoft.IO.Redist. #58359

merged 3 commits into from
Oct 13, 2021

Conversation

teo-tsirpanis
Copy link
Contributor

Fixes #58334.

I removed both the package and all mentions of the MS_IO_REDIST symbol.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 30, 2021
@ghost
Copy link

ghost commented Aug 30, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58334.

I removed both the package and all mentions of the MS_IO_REDIST symbol.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.IO
Milestone: -

@adamsitnik adamsitnik added this to the 7.0.0 milestone Aug 30, 2021
adamsitnik
adamsitnik approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, big thanks @teo-tsirpanis !

Similarly to #57735 we need to wait for more weeks before we merge it (#57735 (comment)).

I am going to add a NO MERGE label to indicate that.

@adamsitnik adamsitnik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 30, 2021
@danmoseley danmoseley requested a review from JeremyKuhne August 30, 2021 21:07
@danmoseley
Copy link
Member

Do we need to communicate with any existing users of this package? (eg., VS or MSBuild?).
Assuming the idea is to port this change into release/6.0, would any of those current users then be forced to "go back" to 5.0 to get any servicing changes?

@stephentoub
Copy link
Member

Assuming the idea is to port this change into release/6.0

I don't believe that's the idea.

@danmoseley
Copy link
Member

I don't believe that's the idea.

Ah - good. I had misinterpreted a "wait until RC2" comment earlier.

@adamsitnik
Copy link
Member

The plan is to remove it in .NET 7, we just a few more weeks to avoid having merge conflicts when backporting changes from System.File.IO to 6.0 branch

stephentoub
stephentoub approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkoritzinsky jkoritzinsky mentioned this pull request Sep 2, 2021
Closed
@jeffhandley
Merge branch 'main' into remove-ms-io-redist
383ddf3 
Conflicts resolved:
	src/libraries/Microsoft.IO.Redist/Microsoft.IO.Redist.sln
	src/libraries/System.Private.CoreLib/src/System/IO/File.cs
@jeffhandley jeffhandley removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 10, 2021
jeffhandley
jeffhandley approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged from main and resolved the conflicts. We can proceed with merging this once CI completes.

@adamsitnik adamsitnik merged commit 09c1a1f into dotnet:main Oct 13, 2021
@teo-tsirpanis teo-tsirpanis deleted the remove-ms-io-redist branch October 13, 2021 20:09
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@stephentoub stephentoub stephentoub approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees
No one assigned
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Delete Microsoft.IO.Redist.csproj
5 participants
@teo-tsirpanis @danmoseley @stephentoub @adamsitnik @jeffhandley