Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print docker info in installers tests #58061

Merged
2 commits merged into from
Aug 25, 2021
Merged

Print docker info in installers tests #58061

2 commits merged into from
Aug 25, 2021

Conversation

agocke
Copy link
Member

@agocke agocke commented Aug 24, 2021

#53587 seems to only occur on Linux, and seems more likely to occur when run under docker (I managed to repro the issue once a couple months ago under docker, and never again). This change will print the docker info for the installer tests, which might help diagnose the problem.

@agocke agocke added the NO-REVIEW Experimental/testing PR, do NOT review it label Aug 24, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@agocke agocke changed the title WIP get docker info Aug 24, 2021
@agocke agocke changed the title get docker info Print docker info in installers tests Aug 25, 2021
@agocke agocke marked this pull request as ready for review August 25, 2021 18:40
@agocke agocke added area-Infrastructure-coreclr and removed NO-REVIEW Experimental/testing PR, do NOT review it labels Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

#53587 seems to only occur on Linux, and seems more likely to occur when run under docker (I managed to repro the issue once a couple months ago under docker, and never again). This change will print the docker info for the installer tests, which might help diagnose the problem.

Author: agocke
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@agocke agocke requested a review from ViktorHofer August 25, 2021 19:12
@agocke
Copy link
Member Author

agocke commented Aug 25, 2021

@ViktorHofer Added two things to try to track down #53587 and #38530

@ghost
Copy link

ghost commented Aug 25, 2021

Hello @agocke!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e0ebe9e into dotnet:main Aug 25, 2021
@agocke agocke deleted the find-docker-info branch August 26, 2021 00:10
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants