Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UpdateRuntimeJson out of props file into Microsoft.NETCore.Platforms project file #57500

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 16, 2021

It's not common to have a target inside a props file. Also as one target related to the runtime.json file already exists in the project's file, moving them together.

@ghost
Copy link

ghost commented Aug 16, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

It's not common to have a target inside a props file. Moving it into the project file to depend on the matching TargetFramework values.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer ViktorHofer requested a review from ericstj August 16, 2021 16:20
@ericstj
Copy link
Member

ericstj commented Aug 16, 2021

Related to this is #53550 which I was expecting to be fixed in 6.0.0 but it looks like it was moved out.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer ViktorHofer merged commit ab0f54a into main Aug 18, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-platformspackage-targetref branch August 18, 2021 07:45
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants