[iOS][libraries] Throw PNSE for Exportable and PersistKeySet flags iOS #57153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsFixes #52434 Until support is added for iOS with regards to Exportable and PersistKeySet flags, throw PNSE on iOS.
|
filipnavara
reviewed
Aug 10, 2021
...raphy.X509Certificates/src/Internal/Cryptography/Pal.iOS/AppleCertificatePal.ImportExport.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Aug 10, 2021
src/libraries/System.Security.Cryptography.X509Certificates/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Aug 11, 2021
src/libraries/System.Security.Cryptography.X509Certificates/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Aug 11, 2021
...raphy.X509Certificates/src/Internal/Cryptography/Pal.iOS/AppleCertificatePal.ImportExport.cs
Show resolved
Hide resolved
bartonjs
reviewed
Aug 11, 2021
...raphy.X509Certificates/src/Internal/Cryptography/Pal.iOS/AppleCertificatePal.ImportExport.cs
Outdated
Show resolved
Hide resolved
|
Functionally LGTM, but left some minor feedback. |
mdh1418
force-pushed
the
iOS_add_x509certificate_flag_pnse
branch
from
eb103cc to
6300e70
Compare
bartonjs
approved these changes
Aug 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52434
Until support is added for iOS with regards to Exportable and PersistKeySet flags, throw PNSE on iOS.