-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RequiresPreviewFeatures attribute #56938
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsUpdates RequiresPreviewFeatures attribute with an optional string message and URL Fixes #56498
|
[Theory] | ||
[InlineData(null, "")] | ||
[InlineData("", null)] | ||
[InlineData("message", "https://aka.ms/obsolete/{0}")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix input string
...ries/System.Runtime/tests/System/Runtime/Versioning/RequiresPreviewFeaturesAttributeTests.cs
Outdated
Show resolved
Hide resolved
[InlineData("message")] | ||
public void Ctor_String_Message(string message) | ||
{ | ||
var attribute = new RequiresPreviewFeaturesAttribute(message) {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var attribute = new RequiresPreviewFeaturesAttribute(message) {}; | |
var attribute = new RequiresPreviewFeaturesAttribute(message); |
...ries/System.Runtime/tests/System/Runtime/Versioning/RequiresPreviewFeaturesAttributeTests.cs
Outdated
Show resolved
Hide resolved
...ries/System.Runtime/tests/System/Runtime/Versioning/RequiresPreviewFeaturesAttributeTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Unrelated build failures. Merging. Thanks for the reviews!! |
Hi, can the ASP.NET Core repo be updated to use the message immediately? Will it just work once the runtime changes flow into aspnetcore and aspnetcore includes a message, or does it also require other changes in VS or the compiler for the message to show up when building? |
Updates RequiresPreviewFeatures attribute with an optional string message and URL
Fixes #56498
cc @jeffhandley @terrajobst