Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x RIDs to DotNetHost* packages #56423

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Add s390x RIDs to DotNetHost* packages #56423

merged 1 commit into from
Aug 30, 2021

Conversation

uweigand
Copy link
Contributor

  • Add linux-s390x and linux-musl-s390x as UnofficialBuildRID
    Ensures RIDs are present in DotNetHost* dispatcher packages

While the runtime.linux-s390x.Microsoft.NETCore.DotNetHost* packages are not currently built as official packages, adding those RIDs to the UnofficialBuildRID list will at least cause those packages to be used if they're built and provided separately. This matches precedent for some other "unofficial" RIDs like freebsd-x64.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 27, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Infrastructure-installer and removed community-contribution Indicates that the PR has been added by a community member labels Jul 27, 2021
* Add linux-s390x and linux-musl-s390x as UnofficialBuildRID
  Ensures RIDs are present in DotNetHost* dispatcher packages
@uweigand
Copy link
Contributor Author

@leecow @crummel does this look reasonable? Can you help get this reviewed?

@akoeplinger akoeplinger merged commit 3845c04 into dotnet:main Aug 30, 2021
@uweigand
Copy link
Contributor Author

Thanks @akoeplinger ! I think it would be really helpful if this could go into .NET 6 as well, so that the default .NET 6 metapackages can pull in separately-bult .NET 6 linux-s390x packages.

@akoeplinger
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1182726738

@uweigand uweigand deleted the s390x-unofficialrid branch August 30, 2021 16:39
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants