Enable EHCONT for some DLLs and for PGO instrumentation
#55942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PGD files used for PGO optimziation need to be collected/produced against binaries with identical compiler features - Enabled `/guard:ehcont` as a compiler option but not as a linker option - Enabled `/guard:ehcont` and `/cetcompat` as a linker options for PGO instrumentation only for now - Once new profile data is published, another PR would follow to enable `/guard:ehcont` and `/cetcompat` as linker options
mangod9
approved these changes
Jul 19, 2021
|
x86 builds are failing with |
|
Yea forgot about that, will fix |
kouvel
added a commit
to kouvel/runtime
that referenced
this pull request
Aug 11, 2021
- Followup to dotnet#55942 - Intended to be merged into a PR that updates to use new PGO profile data collected with the above change - Enabled `/guard:ehcont` as a linker option for EXEs and DLLs - Enabled `/cetcompat` as a linker option for DLLs
kouvel
added a commit
that referenced
this pull request
Aug 12, 2021
* Enable `EHCONT` and `CETCOMPAT` for some binaries on Windows - Followup to #55942 - Intended to be merged into a PR that updates to use new PGO profile data collected with the above change - Enabled `/guard:ehcont` as a linker option for EXEs and DLLs - Enabled `/cetcompat` as a linker option for DLLs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/guard:ehcontas a compiler option but not as a linker option/guard:ehcontand/cetcompatas a linker options for PGO instrumentation only for now/guard:ehcontand/cetcompatas linker options