Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debugger] Fix debugging after hot reloading #55599

Merged
merged 4 commits into from
Jul 14, 2021
Merged

[debugger] Fix debugging after hot reloading #55599

merged 4 commits into from
Jul 14, 2021

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jul 13, 2021

  • If there is no change like add new lines or create new variables, mono_metadata_update_get_updated_method_ppdb will return null.
  • While transforming code it passes on mono_interp_transform_method with same seq_points, only replace on jit_mm->seq_points when it's really changed (in hot reload case)

@thaystg thaystg requested a review from lambdageek July 13, 2021 20:30
@thaystg thaystg requested review from BrzVlad and vargaz as code owners July 13, 2021 20:30
@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details
  • If there is no change like add new lines or create new variables, mono_metadata_update_get_updated_method_ppdb will return null.
  • While transforming code it passes on mono_interp_transform_method with same seq_points, only replace on jit_mm->seq_points when it's really changed (in hot reload case)
Author: thaystg
Assignees: -
Labels:

area-VM-meta-mono
Milestone: -

@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details
  • If there is no change like add new lines or create new variables, mono_metadata_update_get_updated_method_ppdb will return null.
  • While transforming code it passes on mono_interp_transform_method with same seq_points, only replace on jit_mm->seq_points when it's really changed (in hot reload case)
Author: thaystg
Assignees: -
Labels:

area-Debugger-mono, area-VM-meta-mono
Milestone: -

lewing
lewing approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lewing
Copy link
Member

lewing commented Jul 14, 2021 •
edited
Loading

runtime (Installer Build and Test coreclr windows_x64 Release) is a nuget restore error.

A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443)
    A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  Restored D:\workspace\_work\1\s\src\installer\tests\Assets\TestProjects\PortableTestApp\PortableTestApp.csproj (in 25.11 sec).
  Determining projects to restore...
  Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/system.spatial/index.json'.
  A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443)
    A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/system.spatial/index.json'.
  A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443)
    A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.4.21255.9\NuGet.targets(131,5): error : Failed to retrieve information about 'System.Spatial' from remote source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/system.spatial/index.json'. [D:\workspace\_work\1\s\src\installer\tests\Assets\TestProjects\ResourceLookup\ResourceLookup.csproj]
D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.4.21255.9\NuGet.targets(131,5): error :   A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443) [D:\workspace\_work\1\s\src\installer\tests\Assets\TestProjects\ResourceLookup\ResourceLookup.csproj]
D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.4.21255.9\NuGet.targets(131,5): error :   A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. [D:\workspace\_work\1\s\src\installer\tests\Assets\TestProjects\ResourceLookup\ResourceLookup.csproj]
##[error].dotnet\sdk\6.0.100-preview.4.21255.9\NuGet.targets(131,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Failed to retrieve information about 'System.Spatial' from remote source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/system.spatial/index.json'.
  A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443)
  A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@thaystg thaystg merged commit 559011c into dotnet:main Jul 14, 2021
thaystg added a commit to thaystg/runtime that referenced this pull request Jul 14, 2021
@thaystg
Merge branch 'main' of github.com:thaystg/runtime into thays_support_…
a8fb8cf 
…debugger_custom_views

* 'main' of github.com:thaystg/runtime: (125 commits)
  [wasm] [debugger] Support method calls  (dotnet#55458)
  [debugger] Fix debugging after hot reloading (dotnet#55599)
  Inliner: Extend IL limit for profiled call-sites, allow inlining for switches. (dotnet#55478)
  DiagnosticSourceEventSource supports base class properties (dotnet#55613)
  [mono] Fix race during mono_image_storage_open (dotnet#55201)
  [mono] Add wrapper info for native func wrappers. (dotnet#55602)
  H/3 and Quic AppContext switch (dotnet#55332)
  Compression.ZipFile support for Unix Permissions (dotnet#55531)
  [mono] Fix skipping of static methods during IMT table construction. (dotnet#55610)
  Combine System.Private.Xml TrimmingTests projects (dotnet#55606)
  fix name conflict with Configuration class (dotnet#55597)
  Finish migrating RSAOpenSsl from RSA* to EVP_PKEY*
  Disable generic math (dotnet#55540)
  Obsolete CryptoConfig.EncodeOID (dotnet#55592)
  Address System.Net.Http.WinHttpHandler's nullable warnings targeting .NETCoreApp (dotnet#54995)
  Enable Http2_MultipleConnectionsEnabled_ConnectionLimitNotReached_ConcurrentRequestsSuccessfullyHandled (dotnet#55572)
  Fix Task.WhenAny failure mode when passed ICollection of zero tasks (dotnet#55580)
  Consume DistributedContextPropagator in DiagnosticsHandler (dotnet#55392)
  Add property ordering feature (dotnet#55586)
  Reduce subtest count in Reflection (dotnet#55537)
  ...
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@lewing lewing lewing approved these changes

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-Debugger-mono area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaystg @lewing @lambdageek