Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] browser http response stream could be seekable #54749

Merged

Conversation

pavelsavara
Copy link
Member

As discussed here, the unit test is too restrictive.
Fixes #54159

  • test WebAssemblyEnableStreamingResponse
  • browser http response stream could be seekable

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jun 25, 2021
@pavelsavara pavelsavara requested a review from lewing June 25, 2021 16:14
@ghost
Copy link

ghost commented Jun 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

As discussed here, the unit test is too restrictive.
Fixes #54159

  • test WebAssemblyEnableStreamingResponse
  • browser http response stream could be seekable
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Net.Http

Milestone: -

- test WebAssemblyEnableStreamingResponse
@pavelsavara pavelsavara force-pushed the wasm_BrowserHttpContent_seekable2 branch from 07103f7 to 443428b Compare June 28, 2021 09:36
@pavelsavara pavelsavara marked this pull request as ready for review June 28, 2021 11:35
@pavelsavara
Copy link
Member Author

The failing test is unrelated.
System.Security.Cryptography.X509Certificates.Tests.DynamicChainTests.PolicyConstraints_RequireExplicitPolicy on Windows.

@pavelsavara pavelsavara requested a review from lewing June 28, 2021 19:19
@pavelsavara pavelsavara merged commit c3b6307 into dotnet:main Jun 30, 2021
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@pavelsavara pavelsavara deleted the wasm_BrowserHttpContent_seekable2 branch July 29, 2021 08:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm][http] response.Content.ReadAsStreamAsync().CanSeek != false
4 participants