Set the async local just before execution #54133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subscribing to DiagnosticListener.AllListeners replays all created DiagnosticListener instances. Because of this, we need to set the async local just before the execution of the entry point so that we only collect the events that are relevant to the call. Right now, it's also firing with the async local set pre-maturely. - Wrote a concurrency test to make sure it's safe to instantiate the factory in parallel.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Details
Follow up to #54090
|
davidfowl
changed the title
maryamariyan
approved these changes
Jun 14, 2021
| @@ -9,7 +9,7 @@ public class Program | |||
| { | |||
| public static void Main(string[] args) | |||
| { | |||
| Console.ReadLine(); | |||
| System.Threading.Thread.Sleep(-1); | |||
There was a problem hiding this comment.
nit: Thread.Sleep(Timeout.Infinite)
stephentoub
approved these changes
Jun 14, 2021
eerhardt
reviewed
Jun 14, 2021
| @@ -208,6 +204,10 @@ public object CreateHost() | |||
|
|
|||
| try | |||
| { | |||
| // Set the async local to the instance of the HostingListener so we can filter events that | |||
| // aren't scoped to this execution of the entry point. | |||
| _currentListener.Value = this; | |||
There was a problem hiding this comment.
Do you ever have to "unset" this?
There was a problem hiding this comment.
We don't have to because it's on another thread.
eerhardt
approved these changes
Jun 14, 2021
|
Merging this, the test failures are unrelated to the change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiagnosticListener.AllListenersreplays all createdDiagnosticListenerinstances. Because of this, we need to set the async local just before the execution of the entry point so that we only collect the events that are relevant to the call. Right now, it's also firing with the async local set pre-maturely, which makes this race when there are many concurrent executions happening.Follow up to #54090