Integrate changes from NativeAOT branch #53650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes faster virtual method enumerator that should help crossgen2 too
jkotas
requested review from
eiriktsarpalis,
jozkee,
layomia and
steveharter
as code owners
mangod9
reviewed
Jun 5, 2021
| @@ -434,9 +450,6 @@ public static partial class MarshalHelpers | |||
| { | |||
| case NativeTypeKind.Array: | |||
| { | |||
| if (isField || isReturn) | |||
There was a problem hiding this comment.
removal of this check seems to have caused a regression compiling a test containing VT arrays of itself:
.This is now failing outerloop jobs since @trylek switched them to crossgen2 today.
There was a problem hiding this comment.
Could you please share link to the log?
There was a problem hiding this comment.
Here is a log of one of today's outerloop runs. Its generating a stackoverflow with this stack:
at Internal.TypeSystem.Interop.MarshalUtils.IsBlittableType(Internal.TypeSystem.TypeDesc)
at Internal.TypeSystem.Interop.MarshalHelpers.GetArrayElementMarshallerKind(Internal.TypeSystem.ArrayType, Internal.TypeSystem.MarshalAsDescriptor, Boolean)
at Internal.TypeSystem.Interop.MarshalHelpers.GetMarshallerKind(Internal.TypeSystem.TypeDesc, System.Nullable`1<Int32>, Internal.TypeSystem.EmbeddedSignatureData[], Internal.TypeSystem.MarshalAsDescriptor, Boolean, Boolean, Internal.TypeSystem.Interop.MarshallerType, Internal.TypeSystem.Interop.MarshallerKind ByRef)
at Internal.TypeSystem.Interop.MarshalUtils.IsBlittableType(Internal.TypeSystem.TypeDesc)
at Internal.TypeSystem.Interop.MarshalHelpers.GetArrayElementMarshallerKind(Internal.TypeSystem.ArrayType, Internal.TypeSystem.MarshalAsDescriptor, Boolean)
at Internal.TypeSystem.Interop.MarshalHelpers.GetMarshallerKind(Internal.TypeSystem.TypeDesc, System.Nullable`1<Int32>, Internal.TypeSystem.EmbeddedSignatureData[], Internal.TypeSystem.MarshalAsDescriptor, Boolean, Boolean, Internal.TypeSystem.Interop.MarshallerType, Internal.TypeSystem.Interop.MarshallerKind ByRef)
at Internal.TypeSystem.Interop.MarshalUtils.IsBlittableType(Internal.TypeSystem.TypeDesc)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes faster virtual method enumerator that should help crossgen2 too