Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations to netcoreapp3.1 #53358

Merged
merged 2 commits into from
May 28, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 27, 2021

Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations to netcoreapp3.1
and cleaning up conditions so that future tfm upgrades require less project file changes.

Adding NETStandardError markers to prevent available netstandard2.0 assets being picked
instead, same as already done for System.Speech and others.

For more details please see the reasoning in the linked issue.

Contributes to #53282

@ViktorHofer ViktorHofer added area-Infrastructure-libraries breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. labels May 27, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 27, 2021
@ViktorHofer ViktorHofer requested review from ericstj and Anipik May 27, 2021 15:37
@ViktorHofer ViktorHofer self-assigned this May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

projects to netcoreapp3.1 and cleaning up conditions so that future
tfm upgrades require less project file changes.

Adding NETStandardError markers to prevent available netstandard2.0
assets being picked instead, same as already done for System.Speech
and others.

For more details please see the reasoning in the linked issue.

Contributes to #53282

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, breaking-change

Milestone: 6.0.0

@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label May 27, 2021
Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations in
projects to netcoreapp3.1 and cleaning up conditions so that future
tfm upgrades require less project file changes.

Adding NETStandardError markers to prevent available netstandard2.0
assets being picked instead, same as already done for System.Speech
and others.

For more details please see the reasoning in the linked issue.

Contributes to dotnet#53282
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments, other than that looks good

@ViktorHofer ViktorHofer merged commit 4214222 into dotnet:main May 28, 2021
@ViktorHofer ViktorHofer deleted the UpgradeToNetCoreApp31 branch May 28, 2021 11:11
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
@ViktorHofer ViktorHofer removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants