-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip libmonosgen linked library #53240
Conversation
It seems in the .symbols.nupkg package, instead of a stripped .dylib/so and companion .dwarf/.dbg, we've just been shipping unstripped libs. This commit largely duplicates the functions from eng/native/functions.cmake into an MSbuild proj, as our entire logic is already in MSbuild not CMake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably also fixes #45013, though we should check we don't impact XA/XI.
What's the status of this PR? |
I think it's fine, just running into flakiness in unrelated places in testing |
Retriggered the lanes just to be sure :) |
@directhex we would need to strip |
@lateralusX how can i force a dynamic components build on... anything that isn't android? that's one platform i don't have the environment set up locally for |
wait, docker, right. bleh |
I hate docker |
@lateralusX this is looking good locally
|
Sorry, just saw this, there is |
What is the size of the stripped .so files? |
|
It seems in all Mono .symbols.nupkg packages, instead of a stripped .dylib/so and companion .dwarf/.dbg, we've just been shipping unstripped libs (and shipping unstripped libs in the non-symbols packages too). This commit largely duplicates the functions from eng/native/functions.cmake into an MSbuild proj, as our entire install logic is already in MSbuild not CMake. Moving to the common CMake functions would be a much larger task.
This should reduce our install size, and better mirror the rest of dotnet's debug infra & behaviour.