Make DSA.Create, AesCcm, AesGcm, ChaCha20Poly1305 throw PNSE on iOS #52978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Details
|
filipnavara
commented
May 20, 2021
| public static new DSA Create() | ||
| { | ||
| return CreateCore(); | ||
| } |
There was a problem hiding this comment.
The indirection is necessary because of the UnsupportedOSPlatform attributes which would otherwise have to be in 5 different places.
marek-safar
reviewed
May 20, 2021
...aries/System.Security.Cryptography.Algorithms/ref/System.Security.Cryptography.Algorithms.cs
Show resolved
Hide resolved
steveisok
approved these changes
May 20, 2021
27 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52758
Fixes #51332
Fixes #51331
Fixes #51330
Fixes #51370
This PR re-enables all System.Security.Cryptography.* tests to ensure sufficient coverage of the change.