Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Cleanup native build parts of WasmApp.targets #52732

Merged
merged 9 commits into from
May 19, 2021
Merged

[wasm] Cleanup native build parts of WasmApp.targets #52732

merged 9 commits into from
May 19, 2021

Conversation

radical
Copy link
Member

@radical radical commented May 14, 2021

  • Use rsp files for Emcc arguments
  • Split _WasmBuildNative into separate "steps"(targets), which will become useful for dependency checking, and native library support
  • Move things around a bit to be closer to where they are actually used

@radical radical added the arch-wasm WebAssembly architecture label May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use rsp files for Emcc arguments
  • Split _WasmBuildNative into separate "steps"(targets), which will become useful for dependency checking, and native library support
  • Move things around a bit to be closer to where they are actually used
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

radical added 4 commits May 13, 2021 20:28
@radical
[wasm] Split _WasmNativeBuild into separate targets, as steps
5a9f38e 
- this gives us more control over the flow, and will be useful for
  dependency checking (future work)
@radical
[wasm] WasmApp.targets: Decouple aot compilation from native relinking
66b6321
@radical
[wasm] Convert emcc flags from property to item, and use rsp files
6e2e5fa 
The default arguments are still from `emcc-flags.txt`, which will get
converted into a rsp file and used with this, in a future PR.
@radical
cleanup
0605c69
@radical radical force-pushed the wasm-native-prep branch from c7a480b to 0605c69 Compare May 14, 2021 00:31
radical added 2 commits May 13, 2021 20:42
@radical
[wasm] Add new properties to explicitly control optimization level used
5a11740 
.. for compiling native files, and linking.

`$(WasmLinkOptimizationFlag)`, and `$(WasmCompileOptimizationFlag)`

note: right now `emcc-flags.txt` has flags already specified, but that
will go away in favor of only these flags (future work)
@radical
[wasm] Add new properties to specify extra emcc flags
ac571f2 
`$(EmccExtraLDFlags)`, `$(EmccExtraCFlags)`
@radical radical marked this pull request as ready for review May 14, 2021 19:46
@radical radical requested a review from marek-safar as a code owner May 14, 2021 19:46
@radical
Copy link
Member Author

radical commented May 14, 2021

Test failures are unrelated to this PR.

@radical radical mentioned this pull request May 18, 2021
Merged
@radical radical merged commit f6f1220 into dotnet:main May 19, 2021
@radical radical deleted the wasm-native-prep branch May 19, 2021 01:55
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @lewing @karelz