-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to API Compat bug fix around attribute diffing in members #52629
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/dnceng workitem failed when reporting test results to azure devops.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@safern the azdo problem is being tracked by https://github.com/dotnet/core-eng/issues/13026. We also have an FR issue to add retries to this code path to guard against Azdo's 503s: dotnet/arcade#7371 |
There was a regression introduced in API Compat a couple of months ago when adding a new feature, causing Attributes to not be diff'd for TypeMembers (methods, properties, fields, etc).
This reacts to fixing that: dotnet/arcade#7376. This depends on that PR to be merged and produce a new version of API Compat and consume it, so at the moment the build will fail.
It seems like there was a lot of attribute updates from .NET 5.0 to .NET 6.0. I've baselined those errors here but please let me know if any of them shouldn't be baselined and instead fixed.
cc: @vitek-karas @eerhardt @joperezr for the differences in the linker attributes
cc: @jeffhandley @buyaa-n for the differences in OS attributes.
cc: @ericstj for general review.