Use Assembly.Load as first option to load TempAssembly. #52429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
May 7, 2021
| @@ -139,7 +139,7 @@ internal void InitAssemblyMethods(XmlMapping[] xmlMappings) | |||
| /// </devdoc> | |||
| // SxS: This method does not take any resource name and does not expose any resources to the caller. | |||
| // It's OK to suppress the SxS warning. | |||
| [RequiresUnreferencedCode("calls LoadFile")] | |||
| [RequiresUnreferencedCode("calls LoadFrom")] | |||
There was a problem hiding this comment.
This still calls LoadFile, not LoadFrom
There was a problem hiding this comment.
It used to call both. Now it only calls LoadFrom. The call to LoadFile has moved to the new method below.
jkotas
reviewed
May 7, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compilation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 7, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compilation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 7, 2021
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compilation.cs
Outdated
Show resolved
Hide resolved
mconnew
approved these changes
May 19, 2021
HongGit
approved these changes
May 19, 2021
StephenMolloy
force-pushed
the
Ser-TempAssembly.LoadGeneratedAssembly-RevertToLoad
branch
from
ad3c016 to
a48739a
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization: Use Assembly.Load() as first option for loading TempAssembly.
Years ago, Assembly.Load() was apparently not working correctly for the .Net
Core port of serialization, so a hacky workaround of building a filename and
loading an assembly by filename instead was used. This PR brings back the
Assembly.Load() behavior used in NetFx as the primary option, but keeps
the filename workaround as a backup since it's been in place in .Net Core
since 2017.
Fix #1403