Remove indirection in DependencyInjection #52140
Conversation
# Conflicts: # src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteRuntimeResolver.cs # src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngine.cs # src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs # src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/CallSiteTests.cs
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsThe ServiceProviderEngine is a pretty thick abstraction and most of it didn't serve a purpose and can be inlined into the service provider removing the ICallback interface with it.
|
| { | ||
| Func<ServiceProviderEngineScope, object> realizedService = _expressionResolverBuilder.Build(callSite); | ||
| RealizedServices[callSite.ServiceType] = realizedService; |
There was a problem hiding this comment.
These calls were redundant.
...ft.Extensions.DependencyInjection/src/ServiceLookup/Expressions/ExpressionResolverBuilder.cs
Show resolved
Hide resolved
|
@pakrym - can you resolve the conflicts on this PR? |
|
Will do, missed them. |
…tion # Conflicts: # src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs # src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceCollectionContainerBuilderTestExtensions.cs
|
Lets get this for preview6 |
| public RuntimeServiceProviderEngine(IEnumerable<ServiceDescriptor> serviceDescriptors) : base(serviceDescriptors) | ||
| { | ||
| } | ||
| public static RuntimeServiceProviderEngine Instance { get; } = new RuntimeServiceProviderEngine(); |
There was a problem hiding this comment.
I don't think we should do this, it isn't stateless right? I see it's stateless.
| @@ -8,28 +8,30 @@ | |||
|
|
|||
| namespace Microsoft.Extensions.DependencyInjection.ServiceLookup | |||
| { | |||
| internal sealed class ServiceProviderEngineScope : IServiceScope, IServiceProvider, IAsyncDisposable | |||
There was a problem hiding this comment.
nit: let's rename this to ServiceProviderScope on a next PR
...s/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ILEmit/ILEmitResolverBuilder.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
The ServiceProviderEngine is a pretty thick abstraction and most of it didn't serve a purpose and can be inlined into the service provider removing the ICallback interface with it.
Shrink it down to only the service accessor building logic.
Remove ScopeState as it was an extra allocation per scope.