Add AssemblyExtensions.GetApplyUpdateCapabilities method #51954
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/cc @mikem8361 @tmat |
lambdageek
force-pushed
the
add-hotreload-caps
branch
from
0493252 to
301ca01
Compare
|
|
||
| var result = mi.Invoke(null, null); | ||
|
|
||
| Assert.NotNull(result); |
There was a problem hiding this comment.
It's bit odd to check for notnull if the return value is not declared as nullable
There was a problem hiding this comment.
Nullable annotations are just a suggestions. They do not guarantee any behavior. We have similar checks in many other tests.
|
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
| @@ -62,4 +62,13 @@ | |||
| <method signature="System.Void Initialize()" /> | |||
| </type> | |||
| </assembly> | |||
|
|
|||
| <!-- methods used by hot reload. | |||
| TODO: once there's a feature flag, add it to the linker descriptor | |||
There was a problem hiding this comment.
Can we use the Debugger.IsSupported feature switch for now? That's what we did for MetadataUpdateHandlerAttribute.
I can put a PR to fix this.
ghost
locked as resolved and limited conversation to collaborators
Implement a private API that returns the hot reload capabilities of the current runtime.
The corresponding Roslyn API work is dotnet/roslyn#52566
Resolves #50111