Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address more #51528 feedback & do some clean up #51767

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Apr 23, 2021

Follow up for #51528.

@layomia layomia added this to the 6.0.0 milestone Apr 23, 2021
@layomia layomia self-assigned this Apr 23, 2021
@layomia layomia requested a review from jozkee as a code owner April 23, 2021 22:22
@ghost
Copy link

ghost commented Apr 23, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow up for #51528.

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json

Milestone: 6.0.0

Copy link

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@layomia layomia merged commit c9a15a5 into dotnet:main Apr 26, 2021
@layomia layomia deleted the CleanUp branch April 26, 2021 17:23
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants